 |
Post AxakROcYESyBE9DVp2 by [email protected] |
 |
More posts by [email protected] |
|
Post #AxaW4uDRCM47CMqsbo by [email protected] |
|
0 likes, 1 repeats |
|
|
|
I think many people misunderstand the purpose of code review. The purpose of c… |
|
|
|
Post #AxajildboCiFa9Qmoa by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd people think code review is for finding bugs? What do they think tests ar… |
|
|
|
Post #AxajilkLPA6Hv2aAJU by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@ShadSterling @mjd Code review helps with tests. If something is not tested, I�… |
|
|
|
Post #AxajmnuxH58LoLTAYq by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd Our software QA process is focused mainly on software lifecycle management… |
|
|
|
Post #AxajrMXgTzfmM7l54y by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@ShadSterling @mjd Tests need to be written effectively for them to be meaningf… |
|
|
|
Post #AxajrMdi7aUeeoZtTM by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@h3mmy @mjd well yeah, I would be keeping an eye out for bugs along with all th… |
|
|
|
Post #Axak3z1VEmAxB3iw7s by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd oh thank god i'm doing this right then, i never did "code review&… |
|
|
|
Post #Axak9IL2qqIGWwOglM by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd and code reviewer should ask if they dont understand why something was don… |
|
|
|
Post #AxakNXOneYxbIHwehs by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd There needs to be a better way to document code. Half of the effort spent… |
|
|
|
Post #AxakROcYESyBE9DVp2 by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd it is very funny how you said “I think many” instead of “nearly ever… |
|
|
|
Post #AxakROjHpQMDZ2MtJw by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@jason Well, I know many people. but I don't know nearly everyone. |
|
|
|
Post #AxaknZt51YByXaWcz2 by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd I don't know, I usually find a bug in the first few minutes in a code … |
|
|
|
Post #AxakvPnYQ2XpZBg4qO by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjdIn my case, my friend giving me a code review also showed me more tools I h… |
|
|
|
Post #Axal4OfK03v2ex6rqK by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd And a nice side effect is you have at least one other person who knows wha… |
|
|
|
Post #AxalN7C3BXLnyNLNuC by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd It was what happended with New Jersey SMLSo they prefer to rewrite it.http… |
|
|
|
Post #AxalYV66eO5ZINzbeq by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd Also: running the code is not part of the reviewer's duties.CI runs th… |
|
|
|
Post #AxaldpW4A4w04Sfzw8 by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@dolmen @mjd depends on the change, surely? For front-end changes, running the … |
|
|
|
Post #AxalewIIRlv1NjlTYO by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@dave Ah, the triumph of hope over experience. |
|
|
|
Post #Axalhw8TUaa1l8bG4G by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd That's fascinating. I'm not anywhere near coding, but I feel like … |
|
|
|
Post #Axall6e8s0N3E6vJdg by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd something I constantly told junior colleagues (and tried to model in my ow… |
|
|
|
Post #AxaltVkBRTlxNikztA by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd I really like this framing of it. When I’m doing a code review of someon… |
|
|
|
Post #AxalxHqf2zzbRZaTTM by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd application security often does code review specifically to find bugs, and… |
|
|
|
Post #AxalyZdIPWputHwvkO by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd wow, this brilliant. Now do peer review? (Imagine how that would change t… |
|
|
|
Post #AxjZc5ddnZJaSzGLYW by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@ShadSterling @mjd Code review _can_ find bugs, consider code that has tests, b… |
|
|
|
Post #AxjZcGY1EoM0IjiVou by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mrotteveel @ShadSterling Of course it _can_ find bugs, and it often _does_ fin… |
|
|
|
Post #AxkncUVuuBqM8HhAEy by [email protected] |
|
0 likes, 1 repeats |
|
|
|
@mjd How do you know what code reviews are for? |
|
|
|
Post #Axl6BsnYPGGOlAyEam by [email protected] |
|
0 likes, 1 repeats |
|
|
|
@orionkidder @mjd living as I do in Eastern Europe I can report with confidence… |
|
|
|
Post #Axp7v4hprDvzJDFTFo by [email protected] |
|
0 likes, 0 repeats |
|
|
|
This view of code review seems very much more realistic and practical to me.Ima… |
|
|
|
Post #Axp7v6RxNEQAiXpomW by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd it is a great opportunity to get another set of experienced eyes on someth… |
|
|
|
Post #Axp7v9zODNwlh6V3oG by [email protected] |
|
0 likes, 0 repeats |
|
|
|
Folks should read this note upthread from @mjd about code review. A minor mind… |
|
|
|
Post #Axp7vFRvugkYd4tQUi by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd Looking for bad code not wrong code. Got it, I think. |
|
|
|
Post #Axp7vIuP3IJ1MFEhmq by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@mjd eh after going over this (and many of the replies) a few times, I think I … |
|
|
|
Post #Axp7vJ1qbcGDjKieOG by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@diazona @mjd The only reason I might disagree with code review finding bugs is… |
|
|
|
Post #Axp7vJ8EDtMg37hkKu by [email protected] |
|
0 likes, 0 repeats |
|
|
|
@RethinkJeff @diazona I didn't say it didn't find bugs. Of course it fi… |
|
|
|
Post #AxqjQPbS6U2aYj1pya by [email protected] |
|
0 likes, 0 repeats |
|
|
|
From experience: there are several people who are scary good at finding bugs th… |
