improve commitinfo_getstats - stagit-gopher - A git gopher frontend. (mirror) | |
git clone git://bitreich.org/stagit-gopher/ git://enlrupgkhuxnvlhsf6lc3fziv5h2h… | |
Log | |
Files | |
Refs | |
Tags | |
README | |
LICENSE | |
--- | |
commit 8fa0effa9846a18a60d3b6a7c96db42a2775a7c6 | |
parent 8eabe24bdda7003453bbd034d82ebc479e2c76bc | |
Author: Hiltjo Posthuma <[email protected]> | |
Date: Sat, 22 Apr 2017 19:07:07 +0200 | |
improve commitinfo_getstats | |
- reorder: unnecessary allocation when git_patch_from_diff fails. | |
- no need to free patch object when git_patch_from_diff fails. | |
Diffstat: | |
M stagit.c | 7 ++----- | |
1 file changed, 2 insertions(+), 5 deletions(-) | |
--- | |
diff --git a/stagit.c b/stagit.c | |
@@ -110,13 +110,10 @@ commitinfo_getstats(struct commitinfo *ci) | |
err(1, "calloc"); | |
for (i = 0; i < ndeltas; i++) { | |
+ if (git_patch_from_diff(&patch, ci->diff, i)) | |
+ goto err; | |
if (!(di = calloc(1, sizeof(struct deltainfo)))) | |
err(1, "calloc"); | |
- if (git_patch_from_diff(&patch, ci->diff, i)) { | |
- git_patch_free(patch); | |
- free(di); | |
- goto err; | |
- } | |
di->patch = patch; | |
ci->deltas[i] = di; | |