Subj : Re: Hi
To : mark lewis
From : Deon George
Date : Fri Sep 07 2018 11:46 am
mark lewis wrote to Deon George:
ml> i see only that it is reporting and apparently using the 65535 net address
ml> field and not pulling the true net address from the secondary field... i'm
ml> curious to see what others of the MBSE community have to say... something
ml> tells me this is a known problem that is being worked on but i do not know
ml> what the status of that work is... i think andrew was working in this
ml> area...
So I think I found it - and IMHO a bug.
I looked at lib/getheader.c, and and in getheader() I dont see where it
handles
auxNet if origNet = 0xffff.
As per
http://bbsdev.net/fsp/FSP-1040.txt, it states
>> When parsing a
>> Type 2+ packet, if origNet is 65535, the software MUST use the
>> value from the auxNet field.
So I put in this
if (capword & 0x0001) {
if (f->net == 65535) {
Syslog('+', "Point Packet : %d to %d", f->net, t->net);
f->net = buffer[0x26] + (buffer[0x27] << 8);
Syslog('+', "Net Changed : %d to %d", f->net, t->net);
}
And my packet was accepted by my node:
07-Sep-2018 11:34:22 mbfido[147] MBFIDO v1.0.7.6
07-Sep-2018 11:34:22 mbfido[147] Cmd: mbfido toss
+ 07-Sep-2018 11:34:22 mbfido[147] Pass: toss netmail (/opt/mbse/data/inbound)
+ 07-Sep-2018 11:34:22 mbfido[147] Point Packet : 65535 to 633
+ 07-Sep-2018 11:34:22 mbfido[147] Net Changed : 633 to 633
+ 07-Sep-2018 11:34:22 mbfido[147] Packet 2+ : 3 to 3
+ 07-Sep-2018 11:34:22 mbfido[147] Packet : 0433cb8c.pkt type 2+
+ 07-Sep-2018 11:34:22 mbfido[147] From : 3:633/509.1 to 3:633/509
+ 07-Sep-2018 11:34:22 mbfido[147] Dated : 07-10-2018 01:23:53
+ 07-Sep-2018 11:34:22 mbfido[147] Program : Unknown 0xfefe 0.0
I havent check if this point handling is handled anywhere else though - but
could this be a fix? Is sharing that here enough for it to be reviewed?
BTW: It seems the sourceforge code repositoriy is back level (1.0.7.3) -
whereas the download zip file is 1.0.7.6?
...deon
Greetings, Deon George
... "Luke... Luke... Use the MOUSE, Luke" - Obi Wan Gates
--- MBSE BBS v1.0.7.6 (GNU/Linux-ARM)
* Origin: Chinwag | MBSE in Docker on Pi (3:633/509)
