Subj : Re: Small bug

Subj : Re: Small bug
To : g00r00
From : Bj�rn Wiberg
Date : Sun Jan 01 2023 10:59 am

Hello g00r00!

Welcome back, and a Happy New Year to you!

On 30 Dec 2022, g00r00 said the following...
g0> If you have been using A48 or have heard any rumblings I would love to
g0> hear your thoughts on things.

A48 seems to be working fine here, except that I still cannot get the Download via WEB (dlreq) functionality to work -- I always get "File not in queue" when clicking on a file to download it:

http://scbbs.nsupdate.info:61080/dlreq?98b4418f&gwo0.11-sample-win32.lha

Download Batch Queue ERROR
An error occurred while processing your file download request.

Reason: File not in queue

[pid 1567586] gettimeofday({tv_sec=1672566165, tv_usec=632988}, NULL) = 0
[pid 1567586] gettimeofday({tv_sec=1672566165, tv_usec=633077}, NULL) = 0
[pid 1567586] write(3, "+ 2023.01.01 10:42:45 HTTP 1-DLREQ: GET /dlreq?98b4418f&gwo0.11-sample-win32.lha HTTP/1.1\n", 91) = 91
[pid 1567586] open("/home/bbs/mystic/data/98b4418f.dlreq", O_RDONLY|O_LARGEFILE) = 27
[pid 1567586] read(27, "1672573308\n192.168.1.1\n1\n1,841387,0,/mnt/bbs/mystic/files/local/L_UPLOADS/g
wo0.11-sample-win32.lha\n", 4096) = 99
[pid 1567586] close(27) = 0
[pid 1567586] gettimeofday({tv_sec=1672566165, tv_usec=633589}, NULL) = 0
[pid 1567586] gettimeofday({tv_sec=1672566165, tv_usec=633674}, NULL) = 0
[pid 1567586] open("/home/bbs/mystic/data/users.dat", O_RDWR|O_LARGEFILE) = 27

(cut out users.dat contents)

[pid 1567586] gettimeofday({tv_sec=1672566165, tv_usec=634752}, NULL) = 0
[pid 1567586] gettimeofday({tv_sec=1672566165, tv_usec=634818}, NULL) = 0
[pid 1567586] write(3, "+ 2023.01.01 10:42:45 HTTP 1-Authenticated user: Zip\n", 54) = 54
[pid 1567586] open("/home/bbs/mystic/data/98b4418f.dlreq", O_RDONLY|O_LARGEFILE) = 27
[pid 1567586] read(27, "1672573308\n192.168.1.1\n1\n1,841387,0,/mnt/bbs/mystic/files/local/L_UPLOADS/g
wo0.11-sample-win32.lha\n", 4096) = 99
[pid 1567586] read(27, "", 4096) = 0
[pid 1567586] close(27) = 0
[pid 1567586] gettimeofday({tv_sec=1672566165, tv_usec=635303}, NULL) = 0
[pid 1567586] gettimeofday({tv_sec=1672566165, tv_usec=635367}, NULL) = 0
[pid 1567586] write(3, "+ 2023.01.01 10:42:45 HTTP 1-Refused: File not in queue\n", 57) = 57
[pid 1567586] open("/home/bbs/mystic/webroot/cfg/dlreq_error.txt", O_RDONLY|O_LARGEFILE) = 27

It appears that it does not even try to open the actual file to be downloaded.

The MIS log shows:

+ 2023.01.01 10:41:55 HTTP > Connect on slot 1/10 (192.168.1.1)
+ 2023.01.01 10:41:55 HTTP 1-HostName router.asus.com
+ 2023.01.01 10:41:55 HTTP 1-Country Unknown (-)
+ 2023.01.01 10:41:55 HTTP 1-DLREQ: GET /dlreq?98b4418f HTTP/1.1
+ 2023.01.01 10:41:55 HTTP 1-Authenticated user: Zip
+ 2023.01.01 10:41:55 HTTP 1-List Batch
+ 2023.01.01 10:41:55 HTTP 1-Request done
+ 2023.01.01 10:41:55 HTTP > Connect on slot 1/10 (192.168.1.1)
+ 2023.01.01 10:41:55 HTTP 1-HostName router.asus.com
+ 2023.01.01 10:41:55 HTTP 1-Country Unknown (-)
+ 2023.01.01 10:41:56 HTTP > Connect on slot 1/10 (192.168.1.1)
+ 2023.01.01 10:41:56 HTTP 1-HostName router.asus.com
+ 2023.01.01 10:41:56 HTTP 1-Country Unknown (-)
+ 2023.01.01 10:41:57 HTTP 1-DLREQ: GET /dlreq?98b4418f&gwo0.11-sample-win32.lha HTTP/1.1
+ 2023.01.01 10:41:57 HTTP 1-Authenticated user: Zip
+ 2023.01.01 10:41:57 HTTP 1-Refused: File not in queue
+ 2023.01.01 10:42:45 HTTP > Connect on slot 1/10 (192.168.1.1)
+ 2023.01.01 10:42:45 HTTP 1-HostName router.asus.com
+ 2023.01.01 10:42:45 HTTP 1-Country Unknown (-)
+ 2023.01.01 10:42:45 HTTP 1-DLREQ: GET /dlreq?98b4418f&gwo0.11-sample-win32.lha HTTP/1.1
+ 2023.01.01 10:42:45 HTTP 1-Authenticated user: Zip
+ 2023.01.01 10:42:45 HTTP 1-Refused: File not in queue

Any ideas what could be causing this? Maybe something with the newlines in the .dlreq file, or missing <argument> in <argument>=<value> in the URL (only the filename is listed), or trying to match the entire path instead of only the filename, or some anti-spoofing kicking in? Just wild guesses, of course...

My slightly revised webroot files are available here:
https://scbbs.nsupdate.info/files/webroot.tar.gz

They fix a couple of validation errors, HREF link quoting, and add some anti-caching and CSS styling. Free to use as you wish, should you wish. :)

Best regards
Bj�rn

--- Mystic BBS v1.12 A48 (Linux/64)
* Origin: Star Collision BBS, Uppsala, Sweden (2:201/137)