Subj : Funny code section
To : Bo Simonsen
From : mark lewis
Date : Sun Mar 14 2010 09:40 am
ML>Was trying to modify phone number validation and saw this:
ML>
ML> /* Asshole detector */
ML> if (stristr(szNewPhone, "555-1212") || stristr(szNewPhone, "5551212"))
ML> {
ML> Puts(cantskip);
ML> return TRUE;
ML> }
BS> Heh I guess it should match all 555- ;)
no, it shouldn't... one should know how the phone numbers are assigned and for
what purposes... especially when coding POTS capable software... consider a
system that uses a call-back verifier? if someone is being, as the code says,
an asshole, and they put a 555-1212 number in, it will call the information
operator... however, 555-0100 thru 555-0199 are guaranteed by the telcos to not
connect anywhere... these are for fictional use like in movies and tv shows...
you'd be surprised at how many folk think they can call numbers used in movies
and tv shows... you're be more surprised at how many folk actually do dial them
;)
BS> Reading other peoples code can be very entertaining..