Subj : MsgBase.get_msg_header() including votes
To   : Nightfox
From : Digital Man
Date : Thu Nov 23 2023 02:43 pm

 Re: MsgBase.get_msg_header() including votes
 By: Nightfox to Digital Man on Thu Nov 23 2023 11:01 am

> Hi DM,
>
> When using MsgBase.get_msg_header() with the include_votes parameter set to
> true, should the header have valid total_votes and upvotes properties?  I've
> tried using get_msg_header() with the include_votes parameter set to true,
> with a message I know has upvotes, but it seems its total_votes and upvotes
> are 0. However, when I use get_all_msg_headers() and tell it to include
> votes, that message header has the expected values for total_votes and
> upvotes.  I'm not sure if that's by design or if this is a bug.
>
> My Synchronet binaries were built on November 11th.

That's by design. In order to calculate a message's vote totals, the entire messagebase index must be read (and used). Voting on a messsage does not modify the message header of that message but creates a new message header that references the message being voted on. I think the MsgBase.get_index() method could be enhanced to calculate the votes and return the tally in its returned array of index objects, if that helps you (it doesn't do that currently).
--
                                           digital man (rob)

Breaking Bad quote #43:
Congratulations! You're now officially the cute one of the group.
Norco, CA WX: 69.3�F, 52.0% humidity, 10 mph E wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

You are viewing proxied material from bbs.kd3.us. The copyright of proxied material belongs to its original authors. Any comments or complaints in relation to proxied material should be directed to the original authors of the content concerned. Please see the disclaimer for more details.