Subj : Re: JS script cleanup/formatting
To : Digital Man
From : Tracker1
Date : Sat Nov 07 2020 09:44 am
On 11/6/2020 5:49 PM, Digital Man wrote:
>> writeln("\u250C\u250D\u250E\u250F");
>> writeln("\u2510\u2511\u2512\u2513");
>>
>> Also garbled... So probably best to do the CP437 escapes for the
>> characters, but not try to map to utf values... but should put a note to
>> maybe add character translation for unicode/ucs16/utf8 to CP437 output,
>> or as-is for unicode terminals.
>
> There's no such thing as "CP437 escape", so I'm not really sure what
> you're saying. Have you actually looked at existing Synchronet .js
> modules to see how extended ASCII chars are sent?
s/escape/translation/
I'm saying my expectation for the above code would be to see the line
drawing characters with jsexec in a utf-8 terminal... I would expect to
similarly see line drawing characters in a utf-8 connected client if
console.writeln was used. I might expect to see CP437 line characters
in a terminal that wasn't utf-8.
>> tabs it is then... would still suggest eslint or prettier for formatting
>> configured as desired for tabs and strings.
>
> Okay.
>
>> Would you be willing to create an eslint config file that matches your
>> rules? Also, if an auto-format is available, does it really matter?
>
> Yes, it matters.
Was the "yes" part to the first question, or the second, or both?
Aside: if you want me to just go away, please say so.