Subj : syncWXremix and Dial-up
To : Nightfox
From : KenDB3
Date : Thu Jan 07 2016 11:39 pm
Re: syncWXremix and Dial-up
By: Nightfox to KenDB3 on Thu Jan 07 2016 12:52 pm
>> I started using some mock data (since I don't have dialup to test
>> with). I think I figured this out.
>> function getQuerySuffix() {
>> var qs;
>> if (dialup === 'true')
>> ...should be...
>> function getQuerySuffix() {
>> var qs;
>> if (dialup === true)
>> This makes it through the function by grabbing the correct fallback
>> lookup.
>> Triple Equals works... At some point I tried Double Equals instead
>> (stil works). Should I stick with Triple? I read up on the difference,
>> but not sure if one might be better than the other in this particular
>> case.
Ni> Isn't the "=== true" redundant? Saying "if (dialup)" should be enough, and
Ni> it's just as clear as saying "if (dialup === true)", since that has the
Ni> same meaning.
Thanks Nightfox, that is what echicken suggested too, and I think I get the
concept a bit more now. That is what I ended up using in the code.
After I hear back on if it fixed the issue with tbirdsradio, who has a dialup
user, I'll know if I've covered my bases a bit better now. I'll probably
package whats on GitHub right now as the next iteration at that point.
