Subj : newuser.js logic issue
To   : Digital Man
From : Nightfox
Date : Sat Oct 20 2012 10:41 am

Hi DM -

While testing my new user script, I think I may have found a logic issue that
exists in the stock newuser.js.  In the function chk_qwk_id(), the last check
is as follows:
if(system.matchuser(str,true)!=user.number || system.trashcan(str))

I think the purpose of the "system.matchuser(str,true)!=user.number" is to make
sure that the username entered belongs to the current user.  However, if the
newuser.js script needs to ask for a valid QWK ID (i.e., because the
username/alias entered by the user is not a valid QWK ID), then
system.matchuser() will probably return 0 because it's not found.  Since 0 is
different from user.number, anything that the user enters for a QWK ID upon new
user registration will be rejected.

Nightfox


---
� Synchronet � Digital Distortion BBS - digitaldistortionbbs.com

You are viewing proxied material from bbs.kd3.us. The copyright of proxied material belongs to its original authors. Any comments or complaints in relation to proxied material should be directed to the original authors of the content concerned. Please see the disclaimer for more details.